Add Maithili language README.maithili.md#49
Open
VINAY-MANDAL wants to merge 2 commits into
Open
Conversation
alphacrack
requested changes
Jul 20, 2026
alphacrack
left a comment
alphacrack
left a comment
Owner
There was a problem hiding this comment.
This is exactly the kind of contribution #11 hoped for — धन्यवाद! 🙏 The structure mirrors the English README section-for-section and most of it reads naturally. A few things to fix before merge:
Objective content errors (must fix):
- Features list says देवनागरी अंक (
0-9) — the original (and the language!) is०-९. The Devanagari numerals are the whole point of that bullet. - Module-translation example says
गणित→गणित— should beगणित→math.
Structural (should fix):
3. The file isn't linked from README.md — #11 suggested a line at the top of the English README (e.g. [मैथिली मे पढ़ू](README.maithili.md)), otherwise nobody will find it.
4. Leftover untranslated fragments: duplicated "Clone the repo:" above the Maithili line, and the "### 🔧 Install CLI Tool (cross-platform)" heading.
5. The stray first line # README.md — the English README has the same wart, but no need to copy it here.
Coordination notes (non-blocking):
- The keyword table copies the English table's 11 rows, which is already missing 5 mappings (#39). Fine to merge as-is and let #39 update both files together — just flagging so they don't drift separately.
- For future PRs, please branch off
developmentwith a topic branch rather than PRing from your fork'sdevelopmentdirectly (see CONTRIBUTING.md) — it makes follow-up pushes cleaner.
On phrasing (मे vs में, "के साथ", "जैसे" etc.) I'll defer to native speakers — posting a pointer on #11 inviting review would be a great move. Excited to get this in!
alphacrack
added
documentation
Author
|
अहा केत से छियाईं यौ
…On Mon, 20 Jul, 2026, 10:39 pm Bishwas Jha, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
This is exactly the kind of contribution #11
<#11> hoped for —
धन्यवाद! 🙏 The structure mirrors the English README section-for-section
and most of it reads naturally. A few things to fix before merge:
*Objective content errors (must fix):*
1. Features list says देवनागरी अंक (0-9) — the original (and the
language!) is *०-९*. The Devanagari numerals are the whole point of
that bullet.
2. Module-translation example says गणित → गणित — should be *गणित →
math*.
*Structural (should fix):*
3. The file isn't linked from README.md — #11
<#11> suggested a
line at the top of the English README (e.g. [मैथिली मे पढ़ू](
README.maithili.md)), otherwise nobody will find it.
4. Leftover untranslated fragments: duplicated "Clone the repo:" above the
Maithili line, and the "### 🔧 Install CLI Tool (cross-platform)" heading.
5. The stray first line # README.md — the English README has the same
wart, but no need to copy it here.
*Coordination notes (non-blocking):*
- The keyword table copies the English table's 11 rows, which is
already missing 5 mappings (#39
<#39>). Fine
to merge as-is and let #39
<#39> update
both files together — just flagging so they don't drift separately.
- For future PRs, please branch off development with a topic branch
rather than PRing from your fork's development directly (see
CONTRIBUTING.md) — it makes follow-up pushes cleaner.
On phrasing (मे vs में, "के साथ", "जैसे" etc.) I'll defer to native
speakers — posting a pointer on #11
<#11> inviting
review would be a great move. Excited to get this in!
—
Reply to this email directly, view it on GitHub
<#49?email_source=notifications&email_token=BGUAKDXCINOGUUYNUX2XMST5FZG5BA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINZTG4YTMNJVGY2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4737165564>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BGUAKDUJZJ4FT4JYEQLEFVD5FZG5BAVCNFSNUABFKJSXA33TNF2G64TZHM4TOMRRGY3TIMJWHNEXG43VMU5TIOJSGM3TAMZSGI32C5QC>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
हम जनकपुरधाम सँ छी। |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation / Audit Reference
Test Evidence
pytest -vruns green locallypython -m maithili_dsl examples/*.dmaismoke-tested the examplespython -m maithili_dsl --versionshows the expected versionSecurity Considerations
Breaking Changes
Checklist